Comments on: mplayer security hole

By: Reader's Write

Reader's Write — Sat, 03 Sep 2005 15:14:00 +0000

From the post above it is clear that you don’t know the difference.
mplayer (www.mplayerhq.hu) is media player for linux (and many other OS/platform including Window$) and the best media player in existence (no need for 3rd party codec-packs full of malware, plays almost anything – broken files, obscure formats, etc.)

Mplayer is Window$ Media Player which is just plain crap.

By: Reader's Write

Reader's Write — Fri, 02 Sep 2005 23:35:03 +0000

I just stepped in a big steaming pile of security.

By: Reader's Write

Reader's Write — Fri, 02 Sep 2005 23:34:42 +0000

That is a source code patch, which will require a recompile
of the program or just the the library that contains the vulnerability.

Easier to just get a precompiled version but I don’t know if
they made a new build yet…

By: Reader's Write

Reader's Write — Fri, 02 Sep 2005 23:07:47 +0000

i only use mplayer v6.4 and never had any problems.

By: Reader's Write

Reader's Write — Fri, 02 Sep 2005 23:06:11 +0000

the link http://www4.mplayerhq.hu/MPlayer/patches/ad_pcm_fix_20050826.diff

only gives a page with the following garble:

— libmpcodecs/ad_pcm.c.orig 2005-02-27 00:02:09.000000000 +0100
+++ libmpcodecs/ad_pcm.c 2005-08-27 00:11:02.000000000 +0200
@@ -96,8 +96,8 @@

static int decode_audio(sh_audio_t *sh_audio,unsigned char *buf,int minlen,int maxlen)
{
- int len=sh_audio->channels*sh_audio->samplesize-1;
- len=(minlen+len)&(~len); // sample align
+ unsigned len = sh_audio->channels*sh_audio->samplesize;
+ len = maxlen – maxlen % len; // sample align
len=demux_read_data(sh_audio->ds,buf,len);
return len;
}